🐛 fix deadlock when retrieving applied glp

scripts/Addicted/Effectors.reds

@@ -3,14 +3,25 @@ module Addicted
 import Addicted.System.AddictedSystem
 import Addicted.Utils.F
 
+// prevents deadlock on System.CalculateConsumptionModifier (GLPS.GetAppliedPackages)
+public class ContraindicationCallback extends DelayCallback {
+    public let system: wref<AddictedSystem>;
+    public func Call() -> Void {
+        this.system.OnContraindication(ItemID.FromTDBID(t"Items.ripperdoc_med_contraindication"));
+    }
+}
+
 public class IncreaseNeuroBlockerEffector extends Effector {
     protected func ActionOn(owner: ref<GameObject>) -> Void {
         let system = AddictedSystem.GetInstance(owner.GetGame());
+        let scheduler = GameInstance.GetDelaySystem(owner.GetGame());
         // use a fake ID to differentiate, see:
         // - Generic.IsNeuroBlocker
         // - Generic.IsContraindicated
         // - Consumptions.Items
         // - NeuroBlockerTweaks
-        system.OnContraindication(ItemID.FromTDBID(t"Items.ripperdoc_med_contraindication"));
+        let callback: ref<ContraindicationCallback> = new ContraindicationCallback();
+        callback.system = system;
+        scheduler.DelayCallbackNextFrame(callback);
     }
 }

scripts/Addicted/System.reds

@@ -185,10 +185,7 @@ public class AddictedSystem extends ScriptableSystem {
     this.updateSymtomsID = this.delaySystem.DelayCallback(callback, 600., true);
   }
 
-  /// deadlock on packages.GetAppliedPackages
   private func CalculateConsumptionModifier(identifier: TweakDBID) -> Float {
-    return 1.0; // until method fixed
-
     let applied: array<TweakDBID>;
     let stimuli: array<wref<StatModifier_Record>> = [];
     let package: wref<GameplayLogicPackage_Record>;
@@ -198,6 +195,7 @@ public class AddictedSystem extends ScriptableSystem {
 
     if !Generic.IsNeuroBlocker(identifier) { return 1.0; }
     let packages = GameInstance.GetGameplayLogicPackageSystem(this.player.GetGame());
+    // should NEVER be called DIRECTLY from inside a GameplayLogicPackage (deadlock) 
     packages.GetAppliedPackages(this.player, applied);
     while i < ArraySize(applied) {
       id = applied[i];