-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC2024] update helm chart: Add common sub-chart #7581
Conversation
@abhi-bhatra , could you please add a link into CHANGELOG.md? See instructions inside the file on how to do that. |
@abhi-bhatra thanks for the contribution |
Hi @azhavoro Thanks for looking at the contribution. I am sure about the version compatibility. dependencies:
- name: common
repository: https://charts.bitnami.com/bitnami
tags:
- bitnami-common
version: 2.x.x But, still I will run few more test by changing versions of common chart and will see that if it is compatible with Redis, Postgresql and Clickhouse charts. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7581 +/- ##
===========================================
- Coverage 83.47% 83.35% -0.12%
===========================================
Files 373 373
Lines 39739 39722 -17
Branches 3741 3747 +6
===========================================
- Hits 33171 33112 -59
- Misses 6568 6610 +42
|
Wouldn't it be better to pin the common chart version (or at least a minor version) in case of possible backwards compatibility problems in the future? Also, probably need to add a simple test to sure cvat can be deployed without analytics, which would certainly help to quickly detect possible problems in the future. |
@abhi-bhatra , will you be able to complete the PR? |
HI @nmanovic I am working on it, and will complete it by today EOD |
@azhavoro I have pinned the common chart version, but I would like you to point me where to add test for helm charts ? Should I create a bash script ? |
I think it can be separate job in this workflow https://github.com/opencv/cvat/blob/develop/.github/workflows/helm.yml |
Thanks @azhavoro I am adding test case in this workflow. Thanks for guiding me ! |
@azhavoro I have added a simple test case in the workflow, Can you review it ? |
@abhi-bhatra Hello, the test example is not working, could you please fix it? |
I can't merge this PR due to failed tests |
Motivation and context
There has been multiple issue coming due to conflict in common chart version of Redis and Postgresql.
Fixes #7449
Fixes #7507
How has this been tested?
Below is the error:
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.