test: in-app message displayed on wrong page #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
============================================
- Coverage 54.32% 52.78% -1.54%
Complexity 282 282
============================================
Files 109 109
Lines 2511 2582 +71
Branches 355 366 +11
============================================
- Hits 1364 1363 -1
- Misses 1025 1095 +70
- Partials 122 124 +2 ☔ View full report in Codecov by Sentry. |
|
Build available to test |
📏 SDK Binary Size Comparison ReportNo changes detected in SDK binary size ✅ |
Shahroz16
approved these changes
Jun 14, 2024
Comment on lines
+89
to
+91
| parameters = buildMap { | ||
| put("route", route) | ||
| } |
There was a problem hiding this comment.
Suggested change
| parameters = buildMap { | |
| put("route", route) | |
| } | |
| parameters = mapOf("route" to route) |
buildMap seems overkill considering the use-case? 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of MBL-353
Changes
BaseIntegrationTestto allow adding modules when initializing the SDK