Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added try branch for java #2346

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Added try branch for java #2346

merged 1 commit into from
Jun 14, 2024

Conversation

AndreasArvidsson
Copy link
Member

  • Added branch scope for try catch statements in java
  • Added missing iteration scope for if else branch in java

Checklist

  • I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

pokey
pokey approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with very minor comment; feel free to merge

packages/common/src/scopeSupportFacets/scopeSupportFacets.types.ts
@@ -46,6 +46,7 @@ const scopeSupportFacets = [
"branch.if",
"branch.if.iteration",
"branch.try",
"branch.try.iteration",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally left this one out because I couldn't see how it would be useful. But I'm not opposed

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit d0a2b2a Jun 14, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the java_branch branch June 14, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
lang-java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndreasArvidsson @pokey