Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust scope migration #2344

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Rust scope migration #2344

merged 4 commits into from
Jun 14, 2024
+40 −9

Conversation

AndreasArvidsson
Copy link
Member

Checklist

  • [/] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@auscompgeek auscompgeek added scope-migration Migrating scopes to next-gen scope implementation lang-rust labels May 18, 2024
pokey
pokey approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made minor tweak because it seemed awkward to tag className.domain when there's no className. I think that could cause weird breakages

merge if you're happy with my tweak

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit 3a0d9c8 Jun 14, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the rust_migration branch June 14, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
lang-rust scope-migration Migrating scopes to next-gen scope implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndreasArvidsson @pokey @auscompgeek