Create pipeline to lint and test #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurbdiniz
force-pushed
the
test-github-actions-pipeline
branch
from
0f2ca9f to
a8dfeda
Compare
samueloph
requested changes
Dec 7, 2024
There was a problem hiding this comment.
The version of the step actions/checkout needs to be updated to v4 and the tests are currently failing, likely due to the way they are called: shunit2 tests/*, they should instead be called with ./tests/tests.sh.
I have left a few other comments, but they are all things that can be done in a different PR, it's just so I don't forget to open issues to track those features.
arthurbdiniz
force-pushed
the
test-github-actions-pipeline
branch
2 times, most recently
from
55e6932 to
0bd93bc
Compare
arthurbdiniz
changed the title
arthurbdiniz
force-pushed
the
test-github-actions-pipeline
branch
from
0bd93bc to
6ed6f3c
Compare
arthurbdiniz
changed the title
|
I've spoke to Arthur and mentioned that the CI in the PR needs to pass before we review it again. |
arthurbdiniz
force-pushed
the
test-github-actions-pipeline
branch
3 times, most recently
from
5c528c9 to
b0de4a0
Compare
arthurbdiniz
force-pushed
the
test-github-actions-pipeline
branch
from
b0de4a0 to
2f5dc17
Compare
Closes: curl#29 Signed-off-by: Arthur Diniz <[email protected]>
arthurbdiniz
force-pushed
the
test-github-actions-pipeline
branch
from
2f5dc17 to
96505b6
Compare
samueloph
requested changes
Dec 9, 2024
Signed-off-by: Arthur Diniz <[email protected]>
arthurbdiniz
force-pushed
the
test-github-actions-pipeline
branch
from
96505b6 to
a428ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a CI pipeline that sets up
automated testingandshellcheckfor the project.Details:
Created a GitHub Actions workflow to run automated tests and shellcheck on every push and pull request targeting the main branch.
Shellcheck Job:
shellcheckto lint thewcurlscripts.shellcheckon the shell scripts in thetests/directory to identify potential issues.Test Job:
shunit2(required for running tests) based on the operating system.shunit2on thetests/directory to validate the project functionality.Instructions for Testing:
No manual testing is required as this pipeline is automated. It will be triggered on every push and pull request, ensuring that all scripts are linted and tested for issues.
Dependencies
Before merge this Pull Request we need to make sure the #31 is merged otherwise the
shellcheckwill fail.