-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch for cusparseLt 0.6.1 #8074
base: main
Are you sure you want to change the base?
Conversation
Stumbled on this while trying to figure out why the cupy main does not build on a machine it did in December. Tracked it down to cusparseLT 0.5.2 installed on that machine. Rebasing this PR on today's main (f643379) builds fine (great!) but fails down the line with (the specific test file is fairly random)
On a different machine which does not have Hat tip @andfoy for effectively guiding me down this exercise. |
@ev-br could you create an issue for the error that you see (and ping me)? It's not about cuSPARSELt but something else. |
Either an update to this PR or cleaning up the cupy cache locally made the problem reported in #8074 (comment) disappear. So I guess I can confirm that this PR, when rebased on main, works for
|
@ev-br |
Hi @gdaisukesuzuki, Thank you for working on this one, and I'm sorry for keeping you waiting! Could you check @Micket's comments regarding type annotation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order looks different between the docs and the actual header file...
@kmaehashi |
@kmaehashi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM 👍
/test mini |
@kmaehashi |
Hi sorry to keep you waiting! I'll try to get this in this week. |
#6757
This PR is compatible only on CUDA 12 and cusparseLt 0.6.0/1 (not 0.5.0, 0.5.2).