Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently make the following unisusie steps optional #530

Merged
merged 4 commits into from
Feb 20, 2023

Conversation

SamuelSun2000
Copy link
Contributor

To avoid the job exit with errors, I currently muted the unisusie_2 and 3 by suggestion, it will not influence unisusie_1.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gaow
Copy link
Contributor

gaow commented Feb 16, 2023

the patch does not look right ... you cannot make steps optional by just commenting them out -- that's what you did right ? (and without justificcations)

@SamuelSun2000
Copy link
Contributor Author

  1. why mask? what are you trying to achieve? 2. would we ever need to unmask them? 3. if 1 is justifiable and 2 is necessary, what would be the best way to do that?
  1. Now if we run unisusie, it will return an error because unisusie_2 has issues. I blocked it so that people will not get confused, because unisusie_1 successfully yields output without error. Blocking currently is what @hsun3163 suggests to me.

  2. I can see the function is to generate some vcf files. Hao knows the detail @hsun3163 could you plz explain that?

  3. I'm providing two strategies at Remaining problem in unisusie pipeline #527

@gaow
Copy link
Contributor

gaow commented Feb 20, 2023

okay let me merge this then edit .. .

@gaow gaow merged commit 577d14e into cumc:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants