Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge pipelines and clean up #1066

Merged
merged 2 commits into from
Sep 25, 2024
Merged

merge pipelines and clean up #1066

merged 2 commits into from
Sep 25, 2024

Conversation

Chunmingl
Copy link
Contributor

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gaow
Copy link
Contributor

gaow commented Sep 22, 2024

@Chunmingl this file code/pecotmr_integration/python.ipynb is it necessary? Please remove it if not.

@Chunmingl
Copy link
Contributor Author

Chunmingl commented Sep 23, 2024

This file code/pecotmr_integration/python.ipynb is removed

@gaow
Copy link
Contributor

gaow commented Sep 23, 2024

okay for ctwas the codes are also all commented out. I think at this point we should try to test the cTWAS codes and see if it works? Also does ctwas really depends on sos_variable(regional_data) because i have not seen it used?

@Chunmingl
Copy link
Contributor Author

the sos variables were updated after testing on twas and ctwas pipelines together

@gaow gaow merged commit e6d66ef into cumc:main Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants