fix(cubesql): properly convert unsigned types from arrow to dataframe #9029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9029 +/- ##
=======================================
Coverage 82.78% 82.79%
=======================================
Files 221 221
Lines 78494 78521 +27
=======================================
+ Hits 64979 65008 +29
+ Misses 13515 13513 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
max-kammerer
force-pushed
the
mb/fix
branch
5 times, most recently
from
0246455 to
caf95a5
Compare
max-kammerer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like that we need to add new subtypes for ColumnType and TableValue types to support 8 and 16 bits types in more proper/effective manner, but it could break compilation for cube clients and I didn't do it in this pr