This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Fix bug 2207632: infinite loop due to adding VR finalizer during PVC deletion #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deletion Fixing bug 2207632: Resolve issue with VR falling into an infinite loop when attempting to add the finalizer replication.storage.openshift.io/pvc-protection during PVC deletion. Signed-off-by: Benamar Mekhissi <[email protected]>
Madhu-1
reviewed
May 22, 2023
There was a problem hiding this comment.
@BenamarMk we have deprecated the volume replication operator and migrated to kubernetes-csi addons, feel free to post the same change at https://github.com/csi-addons/kubernetes-csi-addons/blob/main/controllers/replication.storage/volumereplication_controller.go
| @@ -188,10 +188,12 @@ func (r *VolumeReplicationReconciler) Reconcile(ctx context.Context, req ctrl.Re | |||
|
|
|||
| return reconcile.Result{}, err | |||
| } | |||
| if err = r.addFinalizerToPVC(logger, pvc); err != nil { | |||
| logger.Error(err, "Failed to add PersistentVolumeClaim finalizer") | |||
| if pvc.GetDeletionTimestamp().IsZero() { | |||
There was a problem hiding this comment.
if the PVC is getting deleted should we just return error at https://github.com/csi-addons/kubernetes-csi-addons/blob/main/controllers/replication.storage/volumereplication_controller.go#L200 and let the next reconcile fail?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue with VR falling into an infinite loop when attempting to add the finalizer "replication.storage.openshift.io/pvc-protection" during PVC deletion.
Fixing bug 2207632
Relevant gchat conversion is found here: