PQ code package update script #323
Conversation
There was a problem hiding this comment.
Thanks, generally looks good with some comments and questions.
I'm also wondering if we should tie the two a little closer togther. We could make libcrux a git submodule for the pqcp repo and then pull it in on that side? Just an idea, trying to see how we can make this as seamless and hassle-free as possible.
… into jonas/pqcp-update-script
github-actions
bot
dismissed
franziskuskiefer’s stale review
Review re-requested
| cp -r "$item" "$pqcp_repo" | ||
| done < "$allowlist" | ||
|
|
||
| python "$libcrux_ml_kem_crate/pqcp/cargo.py" "$libcrux_root" |
There was a problem hiding this comment.
python doesn't exist on many systems. You probably want python3.
| cargo clean | ||
|
|
||
| message="$(printf "mlkem-rust-libcrux PQ code packages update\n\n$(date): libcrux revision $(git -C $libcrux_root rev-parse HEAD)")" | ||
| git switch -c "libcrux-ml-kem-$(git -C $libcrux_root rev-parse HEAD)" |
There was a problem hiding this comment.
This moved the libcrux repo over to this revision. Something doesn't seem quite right here.
|
This PR has been marked as stale due to a lack of activity for 60 days. If you believe this pull request is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days. |
|
We finally need to get back to this. This may be a little stale. But still the thing to do. |
This is part of the planned workflow for packaging
libcrux-ml-kemin the PQ code package. (cf. #302)The script copies files from an allow-list over to the PQCP repo submodule directory. It then runs tests using the default features and upon success creates a signed-off commit in the submodule on a separate branch named after the
libcruxrevision. Pushing needs to be done manually.The allow-list does not include e.g. everything related to C code extraction.