Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out hkdf and hmac modules as standalone crates #305

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

jschneider-bensch
Copy link

This PR pulls out the libcrux::hkdf and libcrux::hmac modules, as well as their dependencies in the libcrux::hacl module into their own crates:

  • libcrux-hkdf which only depends on sys/hacl and
  • libcrux-hmac, which also depends on the new libcrux-hkdf crate

I've also replaced these modules in libcrux with a re-export of the standalone crates' APIs and pruned the libcrux::hacl module of the dead code.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.
We should add the wycheproofs tests to the crates. But looks like they're not there yet. Can you file a follow up?

@jschneider-bensch
Copy link
Author

Thanks, looks good to me. We should add the wycheproofs tests to the crates. But looks like they're not there yet. Can you file a follow up?

I've filed a follow up here: #306

@jschneider-bensch jschneider-bensch merged commit 76c25c4 into dev Jun 11, 2024
39 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/hmac-hkdf-crates branch June 11, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants