Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F*: kyber: add and use diffs for proofs/fstar/extraction-* folders #193

Merged
merged 8 commits into from
Jan 31, 2024

Conversation

W95Psp
Copy link
Contributor

@W95Psp W95Psp commented Jan 29, 2024

Working towards #192

TODOs:

  • add readme describing the workflow
  • check ALL snapshots are up to date will do in a subsequent PR

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the hints really be in there? That makes the patch huge and I don't see why it needs to be there. We could just keep the files around. Same for the Makefile.
So that the patch is really a diff on the F* files.

@W95Psp
Copy link
Contributor Author

W95Psp commented Jan 29, 2024

Mmh, right. This makes sense for hint files, indeed.
But maybe for makefile it's good? things should be pretty similar.

@W95Psp
Copy link
Contributor Author

W95Psp commented Jan 29, 2024

Fixed that, now the script drops hints and makefiles!

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, already much smaller 🙂
But it doesn't apply right now 🤔

I see the vscode config (Kyber.fst.config.json) in there and the PROOFS.md in the patch as well. Should we pull them out too?

No strong opinion on them. This depends on the workflow as well. Speaking of which, let's document how to work with this somewhere in here.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's get this in and then clean things up.

proofs/fstar/README.md Show resolved Hide resolved
proofs/fstar/README.md Show resolved Hide resolved
proofs/fstar/README.md Show resolved Hide resolved
proofs/fstar/README.md Show resolved Hide resolved
@W95Psp W95Psp enabled auto-merge January 31, 2024 14:48
@W95Psp W95Psp merged commit 8dd1e44 into main Jan 31, 2024
14 of 15 checks passed
@W95Psp W95Psp deleted the lucas/fstar-kyber-diffs branch January 31, 2024 15:11
@W95Psp
Copy link
Contributor Author

W95Psp commented Jan 31, 2024

This PR now needs #194.......

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants