Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FP with Nextcloud desktop client and Text app #782

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

GNU-Plus-Windows-User
Copy link
Contributor

Fixes false positive when syncing files from the nextcloud desktop client

@GNU-Plus-Windows-User GNU-Plus-Windows-User marked this pull request as draft July 27, 2023 13:38
@GNU-Plus-Windows-User GNU-Plus-Windows-User changed the title Fix FP with Nextcloud desktop client Fix FP with Nextcloud desktop client and Text app Aug 2, 2023
@GNU-Plus-Windows-User GNU-Plus-Windows-User marked this pull request as ready for review August 2, 2023 00:37
@LaurenceJJones
Copy link
Contributor

Know its a long shot do you have any sample log lines? that you can add to nextcloud-whitelist folder.

In a new version of crowdsec we added the whitelist to the output so if we preemptive get them now we have some data.

@GNU-Plus-Windows-User
Copy link
Contributor Author

@LaurenceJJones I'll add it if I can reproduce the FP.

@GNU-Plus-Windows-User
Copy link
Contributor Author

@LaurenceJJones I was only able to reproduce one of them. I have the cscli alerts inspect -d output for the other is that fine?

@LaurenceJJones
Copy link
Contributor

@LaurenceJJones I was only able to reproduce one of them. I have the cscli alerts inspect -d output for the other is that fine?

hmm might be able to reconstruct the stuff so best to show it and I can work on it 👍🏻

@GNU-Plus-Windows-User
Copy link
Contributor Author

@LaurenceJJones I've just encountered the false positive myself, I've added some logs to the test. I've fixed a new FP with Nextcloud 28 and newer as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants