Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor pkg/database, pkg/models #3022

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

refactor pkg/database, pkg/models #3022

wants to merge 4 commits into from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 17, 2024

No description provided.

@mmetc mmetc added this to the 1.6.3 milestone May 17, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc force-pushed the pkg-models-helpers branch 2 times, most recently from 79a8675 to a781294 Compare May 17, 2024 15:24
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 52.45%. Comparing base (c1e858c) to head (72b8473).

Files Patch % Lines
pkg/models/helpers.go 76.19% 11 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3022      +/-   ##
==========================================
- Coverage   58.41%   52.45%   -5.96%     
==========================================
  Files         268      280      +12     
  Lines       27753    35450    +7697     
==========================================
+ Hits        16212    18596    +2384     
- Misses       9749    15015    +5266     
- Partials     1792     1839      +47     
Flag Coverage Δ
bats 40.14% <69.23%> (-0.04%) ⬇️
unit-linux 34.81% <0.00%> (+0.01%) ⬆️
unit-windows 30.99% <65.15%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the pkg-models-helpers branch 2 times, most recently from ea37691 to 91c824e Compare May 31, 2024 10:00
@mmetc mmetc marked this pull request as ready for review May 31, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants