Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: don't set bouncer last_pull until first connection #3020

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 17, 2024

todo:

  • use bouncer creation date for "cscli bouncers prune" if there's no last_pull; with test

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 7.40741% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 34.08%. Comparing base (c1e858c) to head (d7d7d46).

Files Patch % Lines
pkg/database/decisions.go 0.00% 9 Missing ⚠️
pkg/apiserver/controllers/v1/decisions.go 14.28% 6 Missing ⚠️
cmd/crowdsec-cli/bouncers.go 0.00% 5 Missing ⚠️
cmd/crowdsec-cli/bouncers_table.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3020       +/-   ##
===========================================
- Coverage   58.41%   34.08%   -24.33%     
===========================================
  Files         268      279       +11     
  Lines       27753    35480     +7727     
===========================================
- Hits        16212    12094     -4118     
- Misses       9749    22076    +12327     
+ Partials     1792     1310      -482     
Flag Coverage Δ
bats ?
unit-linux 34.79% <7.14%> (-0.01%) ⬇️
unit-windows 30.95% <7.40%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added this to the 1.6.3 milestone May 17, 2024
@mmetc mmetc force-pushed the nil-bouncer-lastpull branch 2 times, most recently from ce20552 to e57b79b Compare May 31, 2024 21:28
@mmetc mmetc marked this pull request as draft May 31, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants