Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec: respect on_success parameter in hooks #3017

Merged
merged 1 commit into from
May 24, 2024

Conversation

blotus
Copy link
Member

@blotus blotus commented May 15, 2024

Fixes #2929

@blotus blotus added this to the 1.6.2 milestone May 15, 2024
Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented May 15, 2024

/kind fix
/area appsec

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

Attention: Patch coverage is 32.14286% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 27.52%. Comparing base (cc63729) to head (e8428f1).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/appsec/appsec.go 32.14% 17 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3017      +/-   ##
==========================================
+ Coverage   27.46%   27.52%   +0.06%     
==========================================
  Files         399      399              
  Lines       58095    58196     +101     
==========================================
+ Hits        15953    16016      +63     
- Misses      40204    40231      +27     
- Partials     1938     1949      +11     
Flag Coverage Δ
unit-linux 34.84% <37.50%> (-0.02%) ⬇️
unit-windows 25.56% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor buixor self-requested a review May 17, 2024 08:04
Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blotus blotus merged commit 09afcbe into master May 24, 2024
15 checks passed
@blotus blotus deleted the appsec-fix-on_success-hook branch May 24, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AppSec] on_success parameter of hooks is ignored
3 participants