Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable linter: revive(bool-literal-in-expr) #2983

Merged
merged 1 commit into from
Jun 4, 2024
Merged

enable linter: revive(bool-literal-in-expr) #2983

merged 1 commit into from
Jun 4, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 2, 2024

No description provided.

Copy link

github-actions bot commented May 2, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented May 2, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc changed the title lint: reduce bool expressions and branch logic lint: simplify bool expressions and branch logic May 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.42%. Comparing base (9823ed6) to head (7288508).

Files Patch % Lines
pkg/dumps/parser_dump.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2983      +/-   ##
==========================================
+ Coverage   52.39%   52.42%   +0.02%     
==========================================
  Files         280      280              
  Lines       35478    35478              
==========================================
+ Hits        18590    18599       +9     
+ Misses      15043    15039       -4     
+ Partials     1845     1840       -5     
Flag Coverage Δ
bats 40.16% <50.00%> (+0.04%) ⬆️
unit-linux 34.80% <0.00%> (+<0.01%) ⬆️
unit-windows 30.95% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc added this to the 1.6.3 milestone May 2, 2024
@mmetc mmetc marked this pull request as ready for review May 3, 2024 10:53
@mmetc mmetc marked this pull request as draft May 7, 2024 12:20
@mmetc mmetc marked this pull request as ready for review May 13, 2024 14:33
@mmetc mmetc force-pushed the lint-bool branch 3 times, most recently from bb0e676 to 30b0087 Compare June 3, 2024 11:48
@mmetc mmetc changed the title lint: simplify bool expressions and branch logic enable linter: revive(bool-literal-in-expr) Jun 4, 2024
@mmetc mmetc requested a review from sabban June 4, 2024 07:17
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 7313d49 into master Jun 4, 2024
17 checks passed
@mmetc mmetc deleted the lint-bool branch June 4, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants