-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: container discovery via labels #2959
enhance: container discovery via labels #2959
Conversation
@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/kind enhancement |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2959 +/- ##
===========================================
+ Coverage 27.54% 38.80% +11.26%
===========================================
Files 398 402 +4
Lines 57917 58322 +405
===========================================
+ Hits 15953 22634 +6681
+ Misses 40025 33195 -6830
- Partials 1939 2493 +554
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Updated config option to be |
Linked to #1435 |
Fix #2957
Implement container auto discovery via labels set on the container
How to setup:
Add acquisition example:
Then you can launch containers using the following labels:
Under the hood it will check if
crowdsec.enable=true
is set before trying to parse the labels. If no labels are provided it errors as we need to type variables for the parsers.