Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lapi detailed metrics #2858

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

Lapi detailed metrics #2858

wants to merge 29 commits into from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 23, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 72.94118% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 58.07%. Comparing base (8e9e091) to head (6abcafb).

Files Patch % Lines
pkg/apiserver/controllers/v1/usagemetrics.go 40.90% 10 Missing and 3 partials ⚠️
cmd/crowdsec/lpmetrics.go 83.56% 9 Missing and 3 partials ⚠️
pkg/csconfig/console.go 57.14% 6 Missing and 3 partials ⚠️
cmd/crowdsec/crowdsec.go 82.35% 3 Missing ⚠️
pkg/apiclient/usagemetrics.go 78.57% 2 Missing and 1 partial ⚠️
pkg/apiserver/controllers/controller.go 75.00% 1 Missing and 2 partials ⚠️
cmd/crowdsec/serve.go 50.00% 2 Missing ⚠️
cmd/crowdsec/main.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2858      +/-   ##
==========================================
+ Coverage   57.98%   58.07%   +0.08%     
==========================================
  Files         240      243       +3     
  Lines       31040    31190     +150     
==========================================
+ Hits        18000    18113     +113     
- Misses      11411    11437      +26     
- Partials     1629     1640      +11     
Flag Coverage Δ
bats 38.20% <72.94%> (+0.21%) ⬆️
unit-linux 52.13% <11.26%> (-0.13%) ⬇️
unit-windows 47.67% <5.40%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 16.46669% with 2019 lines in your changes missing coverage. Please review.

Project coverage is 50.18%. Comparing base (7d75290) to head (0a247c1).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/database/ent/metric_query.go 0.00% 331 Missing ⚠️
pkg/apiserver/apic_metrics.go 0.00% 144 Missing ⚠️
pkg/database/ent/metric/where.go 1.56% 126 Missing ⚠️
pkg/models/log_processors_metrics.go 28.16% 115 Missing and 10 partials ⚠️
pkg/models/all_metrics.go 10.14% 116 Missing and 8 partials ⚠️
pkg/database/ent/metric_update.go 0.00% 123 Missing ⚠️
pkg/models/base_metrics.go 12.31% 109 Missing and 12 partials ⚠️
pkg/database/ent/metric_create.go 29.87% 101 Missing and 7 partials ⚠️
pkg/models/lapi_metrics.go 0.00% 101 Missing ⚠️
pkg/database/ent/metric.go 0.00% 91 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2858      +/-   ##
==========================================
- Coverage   52.43%   50.18%   -2.25%     
==========================================
  Files         280      305      +25     
  Lines       35451    37849    +2398     
==========================================
+ Hits        18589    18996     +407     
- Misses      15030    16952    +1922     
- Partials     1832     1901      +69     
Flag Coverage Δ
bats 38.85% <19.91%> (-1.33%) ⬇️
unit-linux 34.34% <4.12%> (-0.47%) ⬇️
unit-windows 29.09% <2.44%> (-1.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the lapi-detailed-metrics branch 3 times, most recently from f7c38d2 to 74cf0d9 Compare March 14, 2024 11:59
@blotus blotus requested a review from sabban April 30, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants