-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress bar for one shot acquisition (time machine / cold logs) #2789
base: master
Are you sure you want to change the base?
Conversation
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2789 +/- ##
==========================================
- Coverage 57.98% 57.93% -0.06%
==========================================
Files 240 242 +2
Lines 31040 31082 +42
==========================================
+ Hits 18000 18008 +8
- Misses 11411 11441 +30
- Partials 1629 1633 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
88af598
to
415a641
Compare
77e5ae5
to
18d7d55
Compare
This also disables prometheus metrics in one shot mode because in most cases the port is already taken by LAPI.
This has a log formatter that clears each line before printing overflow information. TODO: fix for windows as well
This also disables prometheus metrics in one shot mode because in most cases the port is already taken by LAPI.
Should work for all datasources, but tested only with files.
Windows should work the same as linux if virtual terminal processing is enabled. If not (win < 10? or it depends on the terminal application?), we should do the same as https://github.com/martinlindhe/color/blob/02ab2eaae10c365c22e6f6f2dac0d9cd496f3016/color_windows.go#L9
I had issues building in windows so would like some testing