This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Android] Support the feature of proxy in Crosswalk #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing patch series with fujunwei/crosswalk@9ea1c3f as its head.
|
Crosswalk for android will update proxy when a PROXY_CHANGE intent is received, but it’s need system permission to send the broadcast, there is also a workaround with reflecting the incompatible api, but it’s too complex to maintain those codes, so implement the new API in XWalkView to set proxy for images/text resources. BUG=XWALK-6769
|
@lincsoon @xuxin @wuhengzhi PTAL. |
|
@fujunwei Please rebase this commit and make it pass the try-bot |
|
@fujunwei What is this PR's status? I would like to see if Crosswalk could support custom proxy settings |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crosswalk for android will update proxy when a PROXY_CHANGE intent is received,
but it’s need system permission to send the broadcast, there is also a workaround with
reflecting the incompatible api, but it’s too complex to maintain those codes, so
implement the new API in XWalkView to set proxy for images/text resources.
BUG=XWALK-6769