This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Rename xwalk::Runtime to xwalk::XWalkContent #2682
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing patch series with pozdnyakov/crosswalk@615a8e1 as its head.
|
|
lgtm when it passes bots |
pozdnyakov
force-pushed
the
rename_Runtime_class
branch
from
615a8e1
to
48b0c85
Compare
|
Testing patch series with pozdnyakov/crosswalk@48b0c85 as its head.
|
|
This is not the complete rename (there are still quite a lot "runtime" variables to be renamed) but this patch is already quite huge and this is just something that can be build (I hope!), I'm gonna complete the renaming with further patches. |
pozdnyakov
force-pushed
the
rename_Runtime_class
branch
from
48b0c85
to
c1f7fc6
Compare
|
Testing patch series with pozdnyakov/crosswalk@c1f7fc6 as its head.
|
pozdnyakov
force-pushed
the
rename_Runtime_class
branch
from
c1f7fc6
to
4bd4ed6
Compare
|
Testing patch series with pozdnyakov/crosswalk@4bd4ed6 as its head.
|
pozdnyakov
force-pushed
the
rename_Runtime_class
branch
from
4bd4ed6
to
2eab532
Compare
|
Testing patch series with pozdnyakov/crosswalk@2eab532 as its head.
|
Rename xwalk::Runtime to xwalk::XWalkContent and stop compiling it on Android.
pozdnyakov
force-pushed
the
rename_Runtime_class
branch
from
2eab532
to
0ca4a32
Compare
|
Testing patch series with pozdnyakov/crosswalk@0ca4a32 as its head.
|
|
What is up with this? rebase? |
|
Is this issue going to be proceeded? |
|
ping @pozdnyakov |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename xwalk::Runtime to xwalk::XWalkContent and stop
compiling it on Android.