Make all the readonly attributes in Device Capabilities valid. #2355
Conversation
|
Testing patch series with kygx-legend/crosswalk@8aeaf52 as its head.
|
|
lgtm, will merge after trybot get green. |
|
It's strange to fail. Seems failed at xwalk_sysapps_browsertest. I will find out the cause. |
|
Yes, the previous try 1785 is green. So should be regression for this commit, please fix. |
kygx-legend
force-pushed
the
readonly
branch
from
8aeaf52
to
be2e17a
Compare
|
Testing patch series with kygx-legend/crosswalk@be2e17a as its head.
|
| @@ -205,7 +234,8 @@ var EventTargetPrototype = function() { | |||
| var listeners = this._event_listeners[type]; | |||
|
|
|||
| for (var i in listeners) | |||
| listeners[i](new this._event_synthesizers[type](type, data)); | |||
| listeners[i](new this._event_synthesizers[type](type, | |||
| createConstClone(data))); | |||
There was a problem hiding this comment.
@halton , I found it failed at this line createConstClone(data) for listener. It should be wrong. I try hard to understand the EventTargetPrototype's structure but can not understand totally. I can not find where the real recieved data is. Try to add createConstClone in line 190, 230 or 245 and all are failed. Could you please have a look at this?
There was a problem hiding this comment.
@legendlee1314 Do you still work on this? I think this point doesn't need to change. Just keep the old design.
|
@halton I tested adding the changed code on crosswalk@35b73bc7d43d8dcab600c2afedcdcf21de0651ee, building with ninja -C out/Release successful, may trybot test again. |
|
@liyingzh yes, please force update the repo, trybot will restart. |
kygx-legend
force-pushed
the
readonly
branch
from
be2e17a
to
a1d7f4a
Compare
|
Testing patch series with kygx-legend/crosswalk@a1d7f4a as its head.
|
|
@liyingzh , it is still failed at xwalk_sysapps_browsertest from log. Could you please reproduce the test? |
Bug=XWALK-2162