This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Printing] Disable print preview to enable basic printing #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is related to crosswalk-project/crosswalk#3851 to enable window.print() functionality. BUG=XWALK-5680
|
Testing patch series with mrunalk/chromium-crosswalk@1cadc70 as its head.
|
|
Why not change the default in Crosswalk's |
|
Ahh I didn't know crosswalk has it's own build/common.gypi too. Thanks. I will close this PR and add this change to the other PR with additional notes as to why we need this change. |
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Bug: 763036 Change-Id: I6820caddfc64889bb35eb00788285a629f8fd623 Reviewed-on: https://chromium-review.googlesource.com/657637 Commit-Queue: Justin Cohen <[email protected]> Reviewed-by: Justin Cohen <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#500606}(cherry picked from commit 77f0bf1) Reviewed-on: https://chromium-review.googlesource.com/677343 Reviewed-by: Olivier Robin <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#374} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to crosswalk-project/crosswalk#3851
to enable window.print() functionality.
BUG=XWALK-5680