Feat/update secrets on expected response #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent Secret Creation/Update on Unexpected Response in
DisposableRequest
Overview
This PR addresses an issue where
DisposableRequest
resources were incorrectly updating secrets even when the API response did not match theexpectedResponse
condition. The expected behavior is that secrets should only be created or updated when the API response passes theexpectedResponse
check.Currently, if the response is unexpected, the
DisposableRequest
does not become ready, but secret injection still occurs, resulting in invalid or incomplete data being injected into the secret. This behavior is problematic because it can lead to unintended or incorrect secret values being propagated.Changes Made
expectedResponse
check.This change ensures that secrets will only be created and updated when the response is valid and meets the criteria specified by the user in
expectedResponse
.Fixes #78
I have:
make reviewable test
to ensure this PR is ready for review.