Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Use router-link instead of a href for some links in the footer #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kinow
Copy link
Contributor

@kinow kinow commented Jan 7, 2019

Hi,

I added a couple of links to routes like /about and /dashboard in my footer, and noticed it was refreshing the page. Then realized it wasn't using router-link.

Not super experienced with Vue.js yet, but tried my best at using an if and rendering the <a> or a <router-link> based on a property of the data entry.

Cheers
Bruno

Copy link
Contributor

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be cleaned up a bit. Ensure that the code style matches that of the project, it should auto-fix errors. Instead of having a new param, we can assume if the link starts with http, it's not a router link.

@johnleider johnleider added the enhancement New feature or request label Nov 1, 2019
@johnleider johnleider self-assigned this Nov 1, 2019
@johnleider johnleider changed the title Use router-link instead of a href for some links in the footer [Feature Request] Use router-link instead of a href for some links in the footer Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants