Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unset): support unset value to zero. (#42) #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zonewave
Copy link

No description provided.

@zonewave
Copy link
Author

I have a error in ci
image

can using goconvey to write tests? @creasty

@creasty
Copy link
Owner

creasty commented Apr 20, 2023

Thank you for suggesting a testing library along the way.
However, it's better to keep the focus of PR on one thing at a time and we should discuss it separately.

Personally, I've always wanted to introduce https://github.com/stretchr/testify which I'm familiar with and is seemingly the most popular choice.

@creasty
Copy link
Owner

creasty commented Apr 20, 2023

As for the error, golangci/golangci-lint#1920 might be the case.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #44 (e4fed12) into master (5220e08) will increase coverage by 1.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   95.97%   97.02%   +1.05%     
==========================================
  Files           2        3       +1     
  Lines         149      202      +53     
==========================================
+ Hits          143      196      +53     
  Misses          3        3              
  Partials        3        3              
Impacted Files Coverage Δ
unset.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zonewave zonewave force-pushed the master branch 3 times, most recently from b832b0b to ebb4636 Compare April 20, 2023 08:51
@zonewave
Copy link
Author

Thank you for suggesting a testing library along the way. However, it's better to keep the focus of PR on one thing at a time and we should discuss it separately.

Personally, I've always wanted to introduce https://github.com/stretchr/testify which I'm familiar with and is seemingly the most popular choice.

ok, I've replaced it with testify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants