-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.16] Enable swap on the node #924
base: release-4.16
Are you sure you want to change the base?
Conversation
After switching to OVN-K we observed increase in memory resource and one way to tackle it to have swap enabled on the node. This PR is try to do following. - Enable only `NodeSwap` feature gate instead complete Tech preview features. - https://docs.openshift.com/container-platform/4.15/rest_api/config_apis/featuregate-config-openshift-io-v1.html - Add `swapaccount=1` to kernel argument which is required for the swap - https://docs.openshift.com/container-platform/4.15/nodes/nodes/nodes-nodes-managing.html#nodes-nodes-swap-memory_nodes-nodes-managing - Add swap feature to kubelet config - Add systemd unit file to create swap and enable it - Extend the disk size by 4GB because that much of space used for swap
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
do you want to create |
No, I just wanted to test it with 4.16 to comment on the Jira ticket. |
This is still not working as expected. |
/retest |
/test e2e-microshift |
@praveenkumar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Testing https://issues.redhat.com/browse/OCPBUGS-31035 one
After switching to OVN-K we observed increase in memory resource and one way to tackle it to have swap enabled on the node.
This PR is try to do following.
NodeSwap
feature gate instead complete Tech preview features. - https://docs.openshift.com/container-platform/4.15/rest_api/config_apis/featuregate-config-openshift-io-v1.htmlswapaccount=1
to kernel argument which is required for the swap - https://docs.openshift.com/container-platform/4.15/nodes/nodes/nodes-nodes-managing.html#nodes-nodes-swap-memory_nodes-nodes-managing