-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telegram: add topics support #1308
Conversation
Looks good after a quick skim without doing my own tests. Thanks for doing the final steps, I'll happily close my PR and branch once this merges. |
sorry to jump in, since latest version (4.29.0), I have now this error and I am unable to use Telegram notification
I guess it might be related to this PR. Any advices on how to solve the issue? |
It might not have been made clear enough on the update - the telegram chat ID was changed from a number to a string. So you need to enclose it with double quotes in your config: notif:
telegram:
token: aabbccdd:11223344
chatIDs:
- - 123456789
+ - "123456789" More examples are in the docs. I hope this helps. |
@chris-1243 Do you have this issue through |
I had the issue through I tried In both case, the use of the double quotes is required |
fixes #948
closes #1125
closes #1305
Carry changes from #1125 but merge topics within
chatIDs
with a specific format and add tests.cc @jon4hz @bytebone