Supported FUNIKI remote AC #2113

QuangThai2297 · 2024-06-29T05:55:17Z

This merge request adds basic support for the FUNIKI remote. This includes support for almostly decode data from remote as power on/off, temperature, mode, fan, clock, timer on/off, swingV, sleep,.. and support sending almostly setting except timer on/off.
For information about this remote, you can refer this issue at #2112
It is old remote model. Data has no checksum byte, and is very easy to decode.
Thanks!

Change argument order and remove unused parameters.

Change argument order and remove unused parameters. Fix a doxygen error Fix a typo/error in the Ptr comment.

QuangThai2297 · 2024-06-29T09:26:18Z

Can anyone help me resolve this failing after check PRs below?
"Library Linter / supported-devices-check (pull_request) Failing after 6s"
I am new here and this is the first time I contribute this project! Thanks!

crankyoldgit

Thanks for this. Looks mostly good.
Can you supply some raw data and what the "raw" A/C message is supposed to be/do etc. i.e. the settings state.

crankyoldgit · 2024-06-29T09:17:21Z

src/ir_Funiki.h

+/// @brief Support for FUNIKI A/C protocols.
+/// @see https://github.com/crankyoldgit/IRremoteESP8266/issues/2112
+
+


Please add the supported devices info here please. It's required for our automatic documentation.
e.g. Like the following for Kelvinator.

IRremoteESP8266/src/ir_Kelvinator.h

Lines 5 to 19 in dc0fd31

// Supports:

// Brand: Kelvinator, Model: YALIF Remote

// Brand: Kelvinator, Model: KSV26CRC A/C

// Brand: Kelvinator, Model: KSV26HRC A/C

// Brand: Kelvinator, Model: KSV35CRC A/C

// Brand: Kelvinator, Model: KSV35HRC A/C

// Brand: Kelvinator, Model: KSV53HRC A/C

// Brand: Kelvinator, Model: KSV62HRC A/C

// Brand: Kelvinator, Model: KSV70CRC A/C

// Brand: Kelvinator, Model: KSV70HRC A/C

// Brand: Kelvinator, Model: KSV80HRC A/C

// Brand: Gree, Model: YAPOF3 remote

// Brand: Gree, Model: YAP0F8 remote

// Brand: Sharp, Model: YB1FA remote

// Brand: Sharp, Model: A5VEY A/C

Thank you! Let me check!

crankyoldgit · 2024-06-29T09:28:31Z

src/ir_Funiki.cpp

+/// Calculate and set the checksum values for the internal state.
+/// @param[in] length The size/length of the state array to fix the checksum of.
+void IRFunikiAC::checksum(const uint16_t length) {
+ (void)(length);
+ // Funiki uses the same checksum alg. as Kelvinator's block checksum.
+ // _.Sum = IRKelvinatorAC::calcBlockChecksum(_.remote_state, length);
+}


This doesn't make sense. If there is no checksum, then you shouldn't need this procedure.
And the validChecksum() function shouldn't be needed. If it is needed, the the checksum should do something.

If they are both un-needed, they should be removed.

crankyoldgit · 2024-06-29T09:30:51Z

src/ir_Funiki.cpp

+/// Set the model of the A/C to emulate.
+/// @param[in] model The enum of the appropriate model.
+void IRFunikiAC::setModel(const funiki_ac_remote_model_t model) {
+ switch (model) {
+ case funiki_ac_remote_model_t::UNKOWN:
+ default: _model = funiki_ac_remote_model_t::UNKOWN;
+ }
+}
+
+/// Get/Detect the model of the A/C.
+/// @return The enum of the compatible model.
+funiki_ac_remote_model_t IRFunikiAC::getModel(void) const { return _model; }


This seems like it doesn't do anything. If the model functions are not needed, they should be removed.

crankyoldgit · 2024-06-29T09:33:36Z

src/ir_Funiki.cpp

+// /// Set the A/C's timer to turn off in X many minutes.
+// /// @param[in] minutes The number of minutes the timer should be set for.
+// /// @note Stores time internally in 30 min units.
+// /// e.g. 5 mins means 0 (& Off), 95 mins is 90 mins (& On). Max is 24 hours.
+// void IRFunikiAC::setTimer(const uint16_t minutes) {
+// uint16_t mins = std::min(kFunikiTimerMax, minutes); // Bounds check.
+// setTimerEnabled(mins >= 30); // Timer is enabled when >= 30 mins.
+// uint8_t hours = mins / 60;
+// // Set the half hour bit.
+// _.TimerHalfHr = (mins % 60) >= 30;
+// // Set the "tens" digit of hours.
+// _.TimerTensHr = hours / 10;
+// // Set the "units" digit of hours.
+// _.TimerHours = hours % 10;
+// }


Please remove the commented out function. Try to avoid including code that doesn't work etc. Someone might think it works and try it.

crankyoldgit · 2024-06-29T09:34:43Z

src/ir_Funiki.cpp

+stdAc::state_t IRFunikiAC::toCommon(void) {
+ stdAc::state_t result{};
+ result.protocol = decode_type_t::FUNIKI;
+ result.model = _model;


If models isn't used, return -1 (I think)

crankyoldgit · 2024-06-29T09:36:25Z

src/ir_Funiki.cpp

+ // for(int i = 0; i < results->rawlen; i++)
+ // {
+ // printf("%d, ",results->rawbuf[i]);
+ // }


Remove these comments please.

crankyoldgit · 2024-06-29T09:41:01Z

src/ir_Funiki.cpp

+ if (strict && nbits != kFunikiBits)
+ return false; // Not strictly a Funiki message.
+
+ // printf("\nlen: %d\n", results->rawlen);


Remove commented code.

crankyoldgit · 2024-06-29T09:44:05Z

src/ir_Funiki.cpp

+ // // Inter-block gap + Data Block #2 (32 bits) + Footer
+ // if (!matchGeneric(results->rawbuf + offset, results->state + 4,
+ // results->rawlen - offset, nbits / 2,
+ // kFunikiBitMark, kFunikiMsgSpace,
+ // kFunikiBitMark, kFunikiOneSpace,
+ // kFunikiBitMark, kFunikiZeroSpace,
+ // kFunikiBitMark, kFunikiMsgSpace, true,
+ // _tolerance, kMarkExcess, false)) return false;
+
+ // // Compliance
+ // if (strict) {
+ // // Verify the message's checksum is correct.
+ // if (!IRFunikiAC::validChecksum(results->state)) return false;
+ // }


Remove commented out code please.

crankyoldgit · 2024-06-29T09:45:23Z

src/ir_Funiki.cpp

+ tole, kMarkExcess, false);
+ if (used == 0) return false;
+ offset += used;
+ // printf("\n ooffset: %d\n", offset);


Remove commented out code please.

src/ir_Funiki.cpp

crankyoldgit · 2024-06-29T09:56:27Z

Can anyone help me resolve this failing after check PRs below? "Library Linter / supported-devices-check (pull_request) Failing after 6s" I am new here and this is the first time I contribute this project! Thanks!

I've given you a code review. See the review comment for the ir_Funiki.h file.

Basically you are missing some info in the header file that we scan for to help automatically build some of the documentation for the project. Namely https://github.com/crankyoldgit/IRremoteESP8266/blob/master/SupportedProtocols.md

QuangThai2297 · 2024-06-30T15:55:19Z

Thanks for this. Looks mostly good. Can you supply some raw data and what the "raw" A/C message is supposed to be/do etc. i.e. the settings state.

Now I have just updated new commit. I removed un-needed something as you recommended. And you can also see "All checks have passed".
For raw message from remote capture, you can refer attached file below:
FUNIKI_remote_AC_Raw_code_decode.txt

QuangThai2297 changed the title ~~supported FUNIKI remote AC~~ Supported FUNIKI remote AC Jun 29, 2024

QuangThai2297 force-pushed the feature/funiki-85bits-remote branch 7 times, most recently from 090ea2e to efbb86b Compare June 29, 2024 08:46

supported FUNIKI remote AC

9170586

QuangThai2297 force-pushed the feature/funiki-85bits-remote branch from efbb86b to 9170586 Compare June 29, 2024 08:50

crankyoldgit added 2 commits June 29, 2024 19:10

Update IRac.h

be0aa11

Change argument order and remove unused parameters.

Update IRac.cpp

ac84bbb

Change argument order and remove unused parameters. Fix a doxygen error Fix a typo/error in the Ptr comment.

crankyoldgit self-assigned this Jun 29, 2024

crankyoldgit added the enhancement label Jun 29, 2024

crankyoldgit self-requested a review June 29, 2024 09:13

crankyoldgit reviewed Jun 29, 2024

View reviewed changes

clean and remove the unused

05030c1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Supported FUNIKI remote AC #2113

Supported FUNIKI remote AC #2113

QuangThai2297 commented Jun 29, 2024

QuangThai2297 commented Jun 29, 2024 •

edited

Loading

crankyoldgit left a comment

crankyoldgit Jun 29, 2024

QuangThai2297 Jun 29, 2024

crankyoldgit Jun 29, 2024

crankyoldgit Jun 29, 2024

crankyoldgit Jun 29, 2024

crankyoldgit Jun 29, 2024

crankyoldgit Jun 29, 2024

crankyoldgit Jun 29, 2024

crankyoldgit Jun 29, 2024

crankyoldgit Jun 29, 2024

crankyoldgit commented Jun 29, 2024

QuangThai2297 commented Jun 30, 2024

		/// @brief Support for FUNIKI A/C protocols.
		/// @see https://github.com/crankyoldgit/IRremoteESP8266/issues/2112

	// Supports:
	// Brand: Kelvinator, Model: YALIF Remote
	// Brand: Kelvinator, Model: KSV26CRC A/C
	// Brand: Kelvinator, Model: KSV26HRC A/C
	// Brand: Kelvinator, Model: KSV35CRC A/C
	// Brand: Kelvinator, Model: KSV35HRC A/C
	// Brand: Kelvinator, Model: KSV53HRC A/C
	// Brand: Kelvinator, Model: KSV62HRC A/C
	// Brand: Kelvinator, Model: KSV70CRC A/C
	// Brand: Kelvinator, Model: KSV70HRC A/C
	// Brand: Kelvinator, Model: KSV80HRC A/C
	// Brand: Gree, Model: YAPOF3 remote
	// Brand: Gree, Model: YAP0F8 remote
	// Brand: Sharp, Model: YB1FA remote
	// Brand: Sharp, Model: A5VEY A/C

Supported FUNIKI remote AC #2113

Are you sure you want to change the base?

Supported FUNIKI remote AC #2113

Conversation

QuangThai2297 commented Jun 29, 2024

QuangThai2297 commented Jun 29, 2024 • edited Loading

crankyoldgit left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crankyoldgit commented Jun 29, 2024

QuangThai2297 commented Jun 30, 2024

QuangThai2297 commented Jun 29, 2024 •

edited

Loading