Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some changes made in the init script #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GarvGupta20
Copy link

hello,
i am a fresher and doing computer science and totally admire your under the hood series and i made 2 specific changes

In init.mjs i provided the argument in the writeFilesync function and in commit.mjs

[acc[key].push(curr) this was creating compilation problem so chanaged it to acc.push(curr);

thank u for this project which helped me learn so much.

@GarvGupta20 GarvGupta20 reopened this Jan 28, 2022
@craigtaub
Copy link
Owner

Thanks for the contribution and so glad to hear you find the series useful.
I'm really busy right now so will try and have a review of this soon. I will just ask you make sure any changes are purely functional related so any personal comments or linting preferences are kept out, thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants