-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEMO] Filter in views #737
base: v3
Are you sure you want to change the base?
Conversation
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (9)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
I am unsure if the way we filter the event now is bulletproof. I am afraid we are opening to a bunch of issues. When we are running a show, there shouldnt be a case for us to show nothing in the event now column. We are always running something. in the second case, we would not be able to use it in public displays since it would show production data (eg. Mic check) to the audience. We can revise the logic, and I think the filter is a good idea, but it would need to be fleshed out as a more robust feature |
can be cleaned up and generalized, but the general idea is there
Recording.2024-01-26.211209.mp4