Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEMO] Filter in views #737

Draft
wants to merge 5 commits into
base: v3
Choose a base branch
from
Draft

[DEMO] Filter in views #737

wants to merge 5 commits into from

Conversation

alex-Arc
Copy link
Collaborator

@alex-Arc alex-Arc commented Jan 26, 2024

can be cleaned up and generalized, but the general idea is there

Recording.2024-01-26.211209.mp4

Copy link
Contributor

coderabbitai bot commented Jan 26, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (9)
  • apps/client/src/common/components/schedule/Schedule.tsx is excluded by: none and included by: none
  • apps/client/src/common/components/schedule/ScheduleContext.tsx is excluded by: none and included by: none
  • apps/client/src/common/components/schedule/ScheduleItem.tsx is excluded by: none and included by: none
  • apps/client/src/common/components/view-params-editor/constants.ts is excluded by: none and included by: none
  • apps/client/src/features/viewers/ViewWrapper.tsx is excluded by: none and included by: none
  • apps/client/src/features/viewers/backstage/Backstage.tsx is excluded by: none and included by: none
  • apps/client/src/features/viewers/countdown/Countdown.tsx is excluded by: none and included by: none
  • apps/client/src/features/viewers/public/Public.tsx is excluded by: none and included by: none
  • apps/client/src/features/viewers/studio/StudioClock.tsx is excluded by: none and included by: none

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@cpvalente
Copy link
Owner

cpvalente commented Jan 27, 2024

I am unsure if the way we filter the event now is bulletproof. I am afraid we are opening to a bunch of issues.

When we are running a show, there shouldnt be a case for us to show nothing in the event now column. We are always running something.
We would either
a) look for the last thing of interest to show, like we do not for public
b) show what is actually running but then mark it as "this is not part of your filter"

in the second case, we would not be able to use it in public displays since it would show production data (eg. Mic check) to the audience.

We can revise the logic, and I think the filter is a good idea, but it would need to be fleshed out as a more robust feature
We should also wait to have the dynamic fields implemented before doing this, since that will majorly change the way we interact with the data

@alex-Arc alex-Arc marked this pull request as draft April 8, 2024 11:02
@alex-Arc alex-Arc changed the title Filter in views [DEMO] Filter in views Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants