Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy] Make legacy solver competition data parseable #2209

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

fleupold
Copy link
Contributor

Description

We've been seeing error message alerts when loading very competition data from the db. This is expected (cf. #2143) however it is pertubating on-call. The alternative would be to downgrade the warning to an error, however I feel we may be losing signal of future breakages in this case.

Changes

  • use serde[(default)] where possible
  • for score, which is a flattened enum that doesn't support defaults (cf. this open issue), we go back to making it an optional. This is fine since with rank-by-surplus we likely no longer need mandatory score anymore anyways.

How to test

Unit test for old transactions data

@fleupold fleupold requested a review from a team as a code owner December 23, 2023 11:16
@mfw78 mfw78 force-pushed the fix_legacy_competition_parsing_error branch from 06bbc90 to 5b4851e Compare December 25, 2023 12:23
@mfw78 mfw78 merged commit d8ab692 into main Dec 25, 2023
8 checks passed
@mfw78 mfw78 deleted the fix_legacy_competition_parsing_error branch December 25, 2023 12:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants