Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base deployment #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Base deployment #94

wants to merge 2 commits into from

Conversation

m-lord-renkse
Copy link

Description

Base deployment contracts.

Copy link

github-actions bot commented Nov 1, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@m-lord-renkse
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@m-lord-renkse m-lord-renkse reopened this Nov 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
fedgiac
fedgiac previously approved these changes Nov 1, 2024
Copy link
Contributor

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but since this has been more difficult than it should have been (see #93 and note that there's no new entry in the broadcast folder) I expect that the PR description will be updated to include the steps that were taken to achieve deterministic deployments and contract verification.

I confirmed that:

  • the contracts exist on Base at the given addresses and have verified code
  • the contracts were created with CREATE2
  • the addresses are the same as those in other networks (meaning that there's no need to actually check that the verified contract code matches that on other networks)

- Some contracts will auto-verify themselves (rare), because they exist in other networks
- Some contracts can be verified with forge e.i. `forge verify-contract --etherscan-api-key $BASESCAN_API_KEY --rpc-url $RPC_URL 0x2f55e8b20D0B9FEFA187AA7d00B6Cbe563605bF5 lib/safe/contracts/handler/ExtensibleFallbackHandler.sol:ExtensibleFallbackHandler`
- For the contracts which can't be verified neither way, the standard json input has to be generated with forge: `forge verify-contract --verifier sourcify --show-standard-json-input --etherscan-api-key $BASESCAN_API_KEY --rpc-url $RPC_URL 0xfdaFc9d1902f4e0b84f65F49f244b32b31013b74 src/ComposableCoW.sol:ComposableCoW > ComposableCoW.json`, and submit the json to the corresponding block explorer

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedgiac speaking with @fleupold about it, we agreed to upload the standard json input format for those contracts requiring it. Where do you think it is the best place to paste them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this specific repository, probably dev/, since it already has the script used to generate networks.json and it's somewhat related.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this specific repository, probably dev/, since it already has the script used to generate networks.json and it's somewhat related.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants