Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arbitrum broadcast file #86

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Add arbitrum broadcast file #86

merged 3 commits into from
Apr 30, 2024

Conversation

MartinquaXD
Copy link
Contributor

Description

Adds broadcast file for deployment on arbitrum.
All contracts deployed and verified.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MartinquaXD
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@MartinquaXD
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Apr 25, 2024
@github-actions
@MartinquaXD has signed the CLA from Pull Request #86
2379862
fleupold
fleupold previously approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit mundane, but could you also update the deployment table in the README.md (we may revamp it to simply list the contract address once and then document which networks it is deployed on)

@MartinquaXD MartinquaXD requested a review from mfw78 April 30, 2024 06:54
mfw78
mfw78 reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@mfw78 mfw78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: weirdness on the sepolia ExtensibleFallbackHandler address

README.md Outdated Show resolved Hide resolved
@MartinquaXD MartinquaXD merged commit 9ea0394 into main Apr 30, 2024
2 checks passed
@MartinquaXD MartinquaXD deleted the arbitrum branch April 30, 2024 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mfw78 mfw78 mfw78 approved these changes

@fleupold fleupold fleupold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinquaXD @fleupold @mfw78