fix: Ensure that coveralls report command succeeds when fail_on_error: false is set
#41
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the `coveralls.sh` script fails to download the coverage reporter, running `coveralls report` resulted in a command-not-found error (error code 127). This failure once occurred multiple times over the course of a day for me, so it's not not just a theoretical concern. Fixes coverallsapp#40.
patbl
changed the title
coveralls command succeeds when fail_on_error: false is setcoveralls report command succeeds when fail_on_error: false is set
patbl
commented
Mar 26, 2024
Comment on lines
+76
to
+82
| set +x | ||
|
|
||
| exit_status=$? | ||
| if [ "${COVERALLS_FAIL_ON_ERROR}" != "1" ]; then | ||
| exit_status=0 | ||
| fi | ||
| exit "${exit_status}" |
There was a problem hiding this comment.
I'm wondering whether it would be OK to just add this:
Suggested change
| set +x | |
| exit_status=$? | |
| if [ "${COVERALLS_FAIL_ON_ERROR}" != "1" ]; then | |
| exit_status=0 | |
| fi | |
| exit "${exit_status}" | |
| exit 0 |
That's what's done here:
Lines 37 to 39 in b48e556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the
coveralls.shscript fails to download the coverage reporter, runningcoveralls reportresulted in a command-not-found error (error code 127). This failure once occurred multiple times over the course of a day for me, so it's not not just a theoretical concern.Fixes #40.