-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Quotation marks are used incorrectly. #23071
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: RiceChuan <[email protected]>
📝 WalkthroughWalkthroughThe pull request involves updates to three architecture decision records (ADRs) in the documentation. The changes primarily focus on refining Protobuf-related specifications, including syntax corrections, inter-module communication mechanisms, and signature handling. The modifications aim to improve the clarity, security, and functionality of module interactions within the Cosmos SDK ecosystem, with a particular emphasis on Protobuf service definitions and module authorization. Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yml 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🧰 Additional context used📓 Path-based instructions (2)docs/architecture/adr-031-msg-service.md (1)Pattern docs/architecture/adr-033-protobuf-inter-module-comm.md (1)Pattern 🔇 Additional comments (2)docs/architecture/adr-031-msg-service.md (1)
The change from curly quotes to straight quotes is correct. Protobuf syntax requires straight quotes ( docs/architecture/adr-033-protobuf-inter-module-comm.md (1)
The change from curly quotes to straight quotes is appropriate for code examples. This maintains consistency and ensures readers can copy-paste the example without syntax issues. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Quotation marks are used incorrectly.
Summary by CodeRabbit