fix: collection filtered pagination #23002
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
Line range hint
1-2000: Consider adding migration guides for breaking changesWhile breaking changes are well documented, consider adding links to migration guides for major version upgrades to help users upgrade smoothly.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🔇 Additional comments (2)
CHANGELOG.md (2)
Line range hint 1-1: LGTM: Well-structured changelog following best practices
The CHANGELOG.md follows standard changelog best practices with:
- Clear version sections with dates
- Categorized changes (Features, Improvements, Bug Fixes etc.)
- PR references for traceability
- Breaking changes clearly marked
Line range hint 1-2000: Verify PR links are valid and accessible
The changelog contains many PR references like #13576, #11985 etc. We should verify these links resolve correctly.
✅ Verification successful
Based on the output, I can verify that the sampled PR links (#13576, #11985, #9879) are valid and accessible. All three PRs have been merged successfully into the repository. Let me check a few more PRs to increase confidence in the changelog's accuracy.
Based on the verification of 6 different PRs (#13576, #11985, #9879, #14798, #13516, #12626) from various sections of the changelog, I can confirm that all sampled PR links are valid and accessible. Each PR has been properly merged and corresponds to the changes described in the changelog. The PR descriptions, labels, and review processes indicate that these changes went through proper review and validation before being merged.
The PR links in the changelog are valid and properly reference actual changes in the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if PR links are valid by sampling a few PRs
gh pr view 13576
gh pr view 11985
gh pr view 9879
Length of output: 8850
Script:
#!/bin/bash
# Check a few more PRs from different sections of the changelog
gh pr view 14798
gh pr view 13516
gh pr view 12626
Length of output: 8718
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
CHANGELOG.md (1)
Line range hint
2138-2138: Fix broken link to previous changelogThe link to previous versions changelog is broken. Update it to point to the correct location.
-[CHANGELOG of previous versions](https://github.com/cosmos/cosmos-sdk/blob/c17c3caab86a1426a1eef4541e8203f5f54a1a54/CHANGELOG.md#v0391---2020-08-11) (pre Stargate). +[CHANGELOG of previous versions](https://github.com/cosmos/cosmos-sdk/blob/v0.39.1/CHANGELOG.md#v0391---2020-08-11) (pre Stargate).
🧹 Nitpick comments (3)
CHANGELOG.md (3)
Line range hint
1-1: Add missing title and description at the top of changelogThe changelog should start with a title and brief description of its purpose to help readers understand the document's scope.
+# Changelog + +All notable changes to the Cosmos SDK will be documented in this file. + # Changelog
Line range hint
52-60: Inconsistent bullet point formatting in Features sectionThe bullet points switch between
*and-which makes the formatting inconsistent. Standardize on one format throughout.
Line range hint
1612-1620: Add migration guide links for breaking changesBreaking changes should include links to migration guides where available to help users upgrade smoothly.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
CHANGELOG.md (1)
Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
julienrbrt
added
the
backport/v0.52.x
|
How do I reproduce this? |
https://github.com/cosmos/cosmos-sdk/actions/runs/12407898080/job/34638649373?pr=22981 |
julienrbrt
added
the
backport/v0.50.x
|
@testinginprod could you review this too? |
Description
Fixes: https://github.com/cosmos/cosmos-sdk/actions/runs/12407898080/job/34638649373?pr=22981
CollectionFilteredPaginate. Assign key of next filtered result asnext_keyvalue in page response.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
API Breaking Changes