Fix cortex query seconds total (#3589) (#3619)

* Fixes `-config.expand-env` requires argument. Fixes #3082 Signed-off-by: Wing924 <[email protected]> * fix Signed-off-by: Wing924 <[email protected]> * Query-Frontend: cortex_query_seconds_total now return seconds not nanoseconds. Signed-off-by: Wing924 <[email protected]> * fix Signed-off-by: Wing924 <[email protected]> * Update CHANGELOG.md Signed-off-by: Marco Pracucci <[email protected]> Co-authored-by: Marco Pracucci <[email protected]> Signed-off-by: Jacob Lisi <[email protected]> Co-authored-by: Wei He <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
cortexproject · Dec 19, 2020 · 2111b0d · 2111b0d
1 parent e8dbbd3
commit 2111b0d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## master / unreleased
 
+## 1.6.0-rc.1
+
+* [BUGFIX] Query-Frontend: `cortex_query_seconds_total` now return seconds not nanoseconds. #3589
+
 ## 1.6.0-rc.0
 
 * [CHANGE] Query Frontend: deprecate `-querier.compress-http-responses` in favour of `-api.response-compression-enabled`. #3544

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-1.6.0-rc.0
+1.6.0-rc.1
diff --git a/pkg/frontend/transport/handler.go b/pkg/frontend/transport/handler.go
@@ -152,7 +152,7 @@ func (f *Handler) reportQueryStats(r *http.Request, queryString url.Values, quer
  }
 
  // Track stats.
- f.querySeconds.WithLabelValues(userID).Add(float64(stats.LoadWallTime()))
+ f.querySeconds.WithLabelValues(userID).Add(stats.LoadWallTime().Seconds())
 
  // Log stats.
  logMessage := append([]interface{}{