Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bam flagging and cell type sanitising #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ktpolanski
Copy link

Two things stemming from practical use:

  • Cell types found in the metadata file later translate to file names, so it feels safer to limit them to [0-9a-zA-Z_] to avoid surprises. I ran into someone giving me a metadata file with / present in the cell types, crashing everything out.
  • In the issue where we talked about running this on multiome, I mentioned that I started processing the BAMs for each sample separately in the case of multi-sample donors. I think it's likely to have multiple samples for a donor these days, and adding the option to prepend the sample ID to the BAM's original CB tag as you do the first step of SComatic is a good way to help with run time. Maybe someone will find it useful. It will make my pipeline cleaner as I won't have a separate file with a handful of changes present.

@ktpolanski
Copy link
Author

While working with SingleCellGenotype.py, I noticed it had a copy of meta_to_dict() so I applied the same changes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant