Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added consent indicators and filters #8003

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Jun 8, 2024

Dependent on coronasafe/care#2255

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Screenshots

Screenshot 2024-06-09 at 5 03 49 AM Screenshot 2024-06-09 at 5 04 10 AM

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@skks1212 skks1212 requested a review from a team as a code owner June 8, 2024 23:33
Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 5:51pm

Copy link

netlify bot commented Jun 8, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 709cc8c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6679b1cd8446eb00085c5052
😎 Deploy Preview https://deploy-preview-8003--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jun 8, 2024

Passing run #2796 ↗︎

0 126 0 0 Flakiness 0

Details:

Added consent indicators and filters
Project: CARE Commit: 709cc8ce2d
Status: Passed Duration: 03:36 💡
Started: Jun 24, 2024 5:54 PM Ended: Jun 24, 2024 5:58 PM

Review all test suite changes for PR #8003 ↗︎

@aparnacoronasafe
Copy link
Member

@skks1212 The message on patient list "16 patients admitted without consent" may be edited to say "16 patients admitted missing consent records"

@skks1212 skks1212 added the P1 breaking issue or vital feature label Jun 11, 2024
@nihal467
Copy link
Member

nihal467 commented Jun 14, 2024

@skks1212
image
image

  • in the badge we mention None, and in the advance filters, the dropdown mention the option as no consents, keep it consistent, in both places

image

  • if a user have multiple facility access and use the advance filter in the patient tab to view only patient list of a particular facility, during this scenario, the missing consent banner count should also filter along with it to just show missing consent of that particular facility.

similar, user apply any advance filter, in the patient tab, it should filter the missing patient consent banner based on that

@skks1212
Copy link
Member Author

@nihal467, are you sure the filters apart from facility filters should change the number shown in the alerts? I believe it is to show patients in that facility (or everywhere) that have no consents regardless of filters. @aparnacoronasafe can you confirm?

@skks1212 skks1212 added question Further information is requested and removed test failed labels Jun 14, 2024
@aparnacoronasafe
Copy link
Member

The experience is better when the number on alert responds to all filters.

If user applies a filter with list showing on 2 results but alert on top says "10 records with no consent record" doesn't look very convincing.

Is there challenge to make it respond to all filters?

You are correct in saying that the need to be able to filter based on facility is not valuable in this case.

@skks1212
Copy link
Member Author

@aparnacoronasafe no challenge, just had a doubt. Made the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to Consent Records flag on patient live encounter with no consent for admission
3 participants