Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added consent indicators and filters #8003

Merged
merged 11 commits into from
Jul 17, 2024
Merged

Added consent indicators and filters #8003

merged 11 commits into from
Jul 17, 2024

Conversation

shivankacker
Copy link
Member

@shivankacker shivankacker commented Jun 8, 2024

Dependent on ohcnetwork/care#2255

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Screenshots

Screenshot 2024-06-09 at 5 03 49 AM Screenshot 2024-06-09 at 5 04 10 AM

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@shivankacker shivankacker requested a review from a team as a code owner June 8, 2024 23:33
Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 6:01am

Copy link

netlify bot commented Jun 8, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bcbe837
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66975e02391a17000871cfe6
😎 Deploy Preview https://deploy-preview-8003--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Jun 8, 2024

Passing run #2880 ↗︎

0 126 0 0 Flakiness 0

Details:

Added consent indicators and filters
Project: CARE Commit: bcbe8371dd
Status: Passed Duration: 02:53 💡
Started: Jul 17, 2024 10:25 AM Ended: Jul 17, 2024 10:28 AM

Review all test suite changes for PR #8003 ↗︎

@aparnacoronasafe
Copy link
Member

@skks1212 The message on patient list "16 patients admitted without consent" may be edited to say "16 patients admitted missing consent records"

@shivankacker shivankacker added the P1 breaking issue or vital feature label Jun 11, 2024
@nihal467
Copy link
Member

nihal467 commented Jun 14, 2024

@skks1212
image
image

  • in the badge we mention None, and in the advance filters, the dropdown mention the option as no consents, keep it consistent, in both places

image

  • if a user have multiple facility access and use the advance filter in the patient tab to view only patient list of a particular facility, during this scenario, the missing consent banner count should also filter along with it to just show missing consent of that particular facility.

similar, user apply any advance filter, in the patient tab, it should filter the missing patient consent banner based on that

@shivankacker
Copy link
Member Author

@nihal467, are you sure the filters apart from facility filters should change the number shown in the alerts? I believe it is to show patients in that facility (or everywhere) that have no consents regardless of filters. @aparnacoronasafe can you confirm?

@shivankacker shivankacker added question Further information is requested and removed test failed labels Jun 14, 2024
@aparnacoronasafe
Copy link
Member

The experience is better when the number on alert responds to all filters.

If user applies a filter with list showing on 2 results but alert on top says "10 records with no consent record" doesn't look very convincing.

Is there challenge to make it respond to all filters?

You are correct in saying that the need to be able to filter based on facility is not valuable in this case.

@shivankacker
Copy link
Member Author

@aparnacoronasafe no challenge, just had a doubt. Made the changes

@shivankacker shivankacker added needs testing and removed question Further information is requested labels Jun 15, 2024
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skks1212 seems multiple cypress tests are failing, please fix those

@khavinshankar khavinshankar merged commit 261255b into develop Jul 17, 2024
62 of 63 checks passed
@khavinshankar khavinshankar deleted the consent-filters branch July 17, 2024 11:49
Copy link

@skks1212 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to Consent Records flag on patient live encounter with no consent for admission
5 participants