fix: input problem on appointment creation on safari #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonasdoubleyou
approved these changes
Aug 9, 2023
| @@ -138,7 +139,7 @@ const AppointmentForm: React.FC<FormProps> = ({ errors, appointmentsCount, onSet | |||
| {/* DURATION */} | |||
| <FormControl isInvalid={'duration' in errors} width={inputWidth}> | |||
| <FormControl.Label>{t('appointment.create.durationLabel')}</FormControl.Label> | |||
| <Select placeholder="Dauer der Unterrichtseinheit" onValueChange={(e) => handleDurationSelection(e)}> | |||
| <Select placeholder="Dauer der Unterrichtseinheit" onValueChange={(duration: string) => handleDurationSelection(duration)}> | |||
There was a problem hiding this comment.
How did this even work before? 😅
| const Select = (props: any) => { | ||
| const isSafari = () => /Safari/.test(navigator.userAgent) && /Apple Computer/.test(navigator.vendor); | ||
|
|
||
| return <NBSelect {...props} selection={isSafari() ? 1 : null} />; |
There was a problem hiding this comment.
Where does this hack come from? Could you add a comment, cause I do not understand how it works?
There was a problem hiding this comment.
So I found the same issue here: GeekyAnts/NativeBase#5111
And the solution therefore is: https://github.com/spr-networks/super/blob/main/frontend/src/components/Select.web.js
I honestly cant explain to you how it works... 😅
Jonasdoubleyou
temporarily deployed
to
user-app-fix-create-app-lyy02s
dhenkel92
added a commit
that referenced
this pull request
Aug 10, 2023
Revert "Merge pull request #322 from corona-school/fix/create-appoint…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had the problem, that only a single character is accepted on controlled input.
So it seems that the problem occures when a select element is present with an input on the same page.
refers to https://github.com/corona-school/project-user/issues/853
Solved