Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix FP for photos app (albums, sharedalbums, places) #36

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix FP for photos app (albums, sharedalbums, places) #36

merged 2 commits into from
Sep 25, 2023

Conversation

mhastu
Copy link
Contributor

@mhastu mhastu commented Sep 19, 2023

Allow text/plain and switch on XML parser for /remote.php/dav/photos/<username>/albums|sharedalbums|places.

Please review the username regex (allowed characters). I'm not sure if the urlencoded '@' character is necessary.

@theseion
Copy link
Contributor

@EsadCetiner would you take a look at this PR too please?

Copy link
Member

@EsadCetiner EsadCetiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theseion theseion merged commit 0503575 into coreruleset:main Sep 25, 2023
3 checks passed
@theseion
Copy link
Contributor

Thank you @mhastu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants