Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve rule configuration #314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: improve rule configuration #314

wants to merge 1 commit into from
+217 −156

Conversation

theseion
Copy link
Contributor

  • Configure rules to update in a separate configuration file
  • Use generic script to configure rules that doesn't rely on exact match of rule
  • Log which rules are configured
  • Log when a rule that should be configured wasn't found

@theseion theseion requested a review from fzipi December 22, 2024 14:34
@theseion theseion force-pushed the improve-rule-configuration branch 3 times, most recently from c4ee535 to 32ebed2 Compare December 22, 2024 18:43
@theseion
feat: improve rule configuration
2f1b656 
- Configure rules to update in a separate configuration file
- Use generic script to configure rules that doesn't rely on exact match
  of rule
- Log which rules are configured
- Log when a rule that should be configured wasn't found
@theseion theseion force-pushed the improve-rule-configuration branch from 32ebed2 to 2f1b656 Compare December 23, 2024 09:29
fzipi
fzipi approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is difficult to have tests for this I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theseion @fzipi