Add Openresty as an webserver option #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 14, 2023 13:44
added 5 commits
December 30, 2023 15:59
|
Can you resolve the conversation for the things addressed already? Thanks! Looking better :) |
theseion
requested changes
Jan 24, 2024
|
Sorry for the long wait @TafkaMax. I think you done a good job and if you are taking responsibility of the image then I don't see why we shouldn't offer it as part of the default build. |
…ith pcre2 support.
|
Updated the image to version 1.25.3. Now openresty can use pcre2 again, which is nice. Tested in my environment and build successfully and works aswell. |
theseion
requested changes
Jan 27, 2024
Co-authored-by: Max Leske <[email protected]>
Co-authored-by: Max Leske <[email protected]>
Co-authored-by: Max Leske <[email protected]>
Co-authored-by: Max Leske <[email protected]>
Co-authored-by: Max Leske <[email protected]>
Co-authored-by: Max Leske <[email protected]>
theseion
approved these changes
Jan 27, 2024
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have successfully created and made Openresty use Modsecurity. Because Openresty is based on Nginx it was doable.
There are some nuances.
Because the official Openresty Docker Image is created differently than the Nginx one, then there is no usage of 'nginx' user. Openresty does not use 'docker-entrypoint' logic, so I copied that logic from the original Nginx repository.
If you have any more questions I am happy to answer them.
I also added a simple gitlab-ci.yml file, because that is what I use with the integrated gitlab registry, but it might be too specific to add.
Currently I only added the Alpine build option and only for linux/amd64.