Apply suggestions from code review

coreruleset · Dec 8, 2024 · 7a38a8a · 7a38a8a
1 parent b158dbb
commit 7a38a8a
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 3 deletions.
diff --git a/nginx/Dockerfile b/nginx/Dockerfile
@@ -118,7 +118,6 @@ ENV \
     CORS_HEADER_403_ALLOW_METHODS="GET, POST, PUT, DELETE, OPTIONS" \
     CORS_HEADER_403_CONTENT_TYPE="text/plain" \
     CORS_HEADER_403_MAX_AGE=3600 \
-    CORS_HEADER_ACCESS_CONTROL_ALLOW_HEADERS="*" \
     DNS_SERVER= \
     ERRORLOG=/var/log/nginx/error.log \
     KEEPALIVE_TIMEOUT=60s \

diff --git a/nginx/Dockerfile-alpine b/nginx/Dockerfile-alpine
@@ -111,7 +111,6 @@ ENV \
     CORS_HEADER_403_ALLOW_METHODS="GET, POST, PUT, DELETE, OPTIONS" \
     CORS_HEADER_403_CONTENT_TYPE="text/plain" \
     CORS_HEADER_403_MAX_AGE=3600 \
-    CORS_HEADER_ACCESS_CONTROL_ALLOW_HEADERS="*" \
     DNS_SERVER= \
     ERRORLOG=/var/log/nginx/error.log \
     KEEPALIVE_TIMEOUT=60s \

diff --git a/nginx/templates/includes/cors.conf.template b/nginx/templates/includes/cors.conf.template
@@ -2,4 +2,3 @@ more_set_headers -s 403 'Content-Type' '${CORS_HEADER_403_CONTENT_TYPE}';
 more_set_headers -s 403 'Access-Control-Allow-Origin' '${CORS_HEADER_403_ALLOW_ORIGIN}';
 more_set_headers -s 403 'Access-Control-Max-Age' '${CORS_HEADER_403_MAX_AGE}';
 more_set_headers -s 403 'Access-Control-Allow-Methods' '${CORS_HEADER_403_ALLOW_METHODS}';
-more_set_headers 'Access-Control-Allow-Headers' '${CORS_HEADER_ACCESS_CONTROL_ALLOW_HEADERS}';