login1: add NewWithConnection and RebootWithContext methods #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some small improvements to
login1
package, namely changes tests to use blackbox approach to avoid building up the tech debt by adding new tests without doing so in the first place.Then adds
NewWithConnection
method together with tests as a new constructor to login1.Conn (#389), which allows re-using and mocking D-Bus connection so remaining method calls can be tested.Finally,
RebootWithContext
method is added as an replacement and improved version ofReboot
.Closes #387
Closes #391
Submitted code is based on the work I've done in flatcar/flatcar-linux-update-operator#112.